swissmakers_gmbh/fail2ban-ui
12
1
Fork 0
mirror of https://github.com/swissmakers/fail2ban-ui.git synced 2026-04-17 05:53:15 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix typo in the opensense integration to fix the deletion API request

Browse Source
This commit is contained in:
Michael Reber
2026-02-14 14:51:55 +01:00
parent 6eb56acc15
commit 43bc278892
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/integrations/opnsense.go
View File

@@ -52,16 +52,12 @@ func (o *opnsenseIntegration) UnblockIP(req Request) error {
if err := o.Validate(req.Config); err != nil { if err := o.Validate(req.Config); err != nil {
return err return err
} }
return o.callAPI(req, "del", req.IP) return o.callAPI(req, "delete", req.IP)
} }
func (o *opnsenseIntegration) callAPI(req Request, action, ip string) error { func (o *opnsenseIntegration) callAPI(req Request, action, ip string) error {
cfg := req.Config.OPNsense cfg := req.Config.OPNsense
// OPNsense uses /api/firewall/alias_util/{action}/{alias_name}
apiURL := strings.TrimSuffix(cfg.BaseURL, "/") + fmt.Sprintf("/api/firewall/alias_util/%s/%s", action, cfg.Alias) apiURL := strings.TrimSuffix(cfg.BaseURL, "/") + fmt.Sprintf("/api/firewall/alias_util/%s/%s", action, cfg.Alias)
// Request body for OPNsense
payload := map[string]string{ payload := map[string]string{
"address": ip, "address": ip,
} }
@@ -89,8 +85,6 @@ func (o *opnsenseIntegration) callAPI(req Request, action, ip string) error {
return fmt.Errorf("failed to create OPNsense request: %w", err) return fmt.Errorf("failed to create OPNsense request: %w", err)
} }
httpReq.Header.Set("Content-Type", "application/json") httpReq.Header.Set("Content-Type", "application/json")
// OPNsense uses Basic Auth with API key as username and API secret as password
auth := base64.StdEncoding.EncodeToString([]byte(cfg.APIKey + ":" + cfg.APISecret)) auth := base64.StdEncoding.EncodeToString([]byte(cfg.APIKey + ":" + cfg.APISecret))
httpReq.Header.Set("Authorization", "Basic "+auth) httpReq.Header.Set("Authorization", "Basic "+auth)
@@ -106,8 +100,6 @@ func (o *opnsenseIntegration) callAPI(req Request, action, ip string) error {
return fmt.Errorf("OPNsense API request to %s failed: %w (check base URL, network connectivity, and API credentials)", apiURL, err) return fmt.Errorf("OPNsense API request to %s failed: %w (check base URL, network connectivity, and API credentials)", apiURL, err)
} }
defer resp.Body.Close() defer resp.Body.Close()
// Read response body for better error messages
bodyBytes, _ := io.ReadAll(resp.Body) bodyBytes, _ := io.ReadAll(resp.Body)
bodyStr := strings.TrimSpace(string(bodyBytes)) bodyStr := strings.TrimSpace(string(bodyBytes))