swissmakers_gmbh/fail2ban-ui
12
1
Fork 0
mirror of https://github.com/swissmakers/fail2ban-ui.git synced 2026-04-17 14:03:15 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

When address is empty, detail is explicitly set to an empty array to clear any existing detail items in pfSense

Browse Source
This commit is contained in:
Michael Reber
2026-01-28 14:31:58 +01:00
parent 63ee6a40d7
commit f00c1c1b22
1 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
internal/integrations/pfsense.go
View File

@@ -313,27 +313,25 @@ func (p *pfSenseIntegration) updateAlias(client *http.Client, baseURL, apiToken
apiURL := baseURL + "/api/v2/firewall/alias"
// Prepare PATCH payload - include id in the request body
// pfSense requires that detail cannot have more items than address
// Always include detail array to ensure it matches address length
detailToSend := alias.Detail
if len(detailToSend) > len(alias.Address) {
// Truncate detail to match address length
detailToSend = detailToSend[:len(alias.Address)]
}
// If address is empty, detail must also be empty
if len(alias.Address) == 0 {
detailToSend = []string{}
}
patchPayload := map[string]interface{}{
"id": alias.ID,
"name": alias.Name,
"type": alias.Type,
"descr": alias.Descr,
"address": alias.Address,
}
// pfSense requires that detail cannot have more items than address
// If address is empty, detail must also be empty
if len(alias.Address) > 0 {
// Only include detail if address has items, and ensure detail length matches address length
detailToSend := alias.Detail
if len(detailToSend) > len(alias.Address) {
// Truncate detail to match address length
detailToSend = detailToSend[:len(alias.Address)]
}
// Always include detail array when address has items (even if empty) to maintain consistency
patchPayload["detail"] = detailToSend
} else {
// When address is empty, explicitly set detail to empty array
patchPayload["detail"] = []string{}
"detail": detailToSend, // Always include detail to ensure it's cleared when address is empty
}
data, err := json.Marshal(patchPayload)